search

fsr-de / myHPI

Django/Wagtail page serving myhpi.de
https://myhpi.de
11 stars 11 forks source link

Responsive Meta Panel #525

Closed SilvanVerhoeven closed 2 months ago

SilvanVerhoeven commented 7 months ago

Closes #275, closes #329, closes #53 Replaces stale #285

SilvanVerhoeven commented 7 months ago

Headings on minutes look like this for me: image

Correct, those are permalinks to the headings (so one can share a link that jumps to specific section on the page)

jeriox commented 7 months ago

grafik the content is not using the full width of the screen here

jeriox commented 7 months ago

Correct, those are permalinks to the headings (so one can share a link that jumps to specific section on the page)

I like the idea of having those, but I'm also not so happy with the proposed layout. I don't think that most people get that the # after the title is meant to be the permalink. And the arrow-out-of-the-box-icon is only used for external links, but not internal ones. So I think its odd that is now part of another internal link.

abc013 commented 6 months ago

I like the idea of having those, but I'm also not so happy with the proposed layout. I don't think that most people get that the # after the title is meant to be the permalink. And the arrow-out-of-the-box-icon is only used for external links, but not internal ones. So I think its odd that is now part of another internal link.

(Just to give some additional Senf to the Wurst)

Personally, I really like GitHub's approach to that: Just showing a 'link' icon behind/before the title should be enough imho (It's hover-on on GitHub, but doesn't have to be here). image

SilvanVerhoeven commented 2 months ago

the arrow-out-of-the-box-icon is only used for external links, but not internal ones. So I think its odd that is now part of another internal link.

@jeriox Agreed, but I am not sure I can do much about this at that point. Currently, all links not created by internal references get this arrow icon. I think this should be reworked in general in another branch

SilvanVerhoeven commented 2 months ago

Personally, I really like GitHub's approach to that: Just showing a 'link' icon behind/before the title should be enough imho (It's hover-on on GitHub, but doesn't have to be here).

Unfortunately, the used permanent link extension only allows to insert strings. The UTF 8 link emoji looks horrible on the latest windows 10, that's why we keep the # for now.

dropforge commented 2 months ago

Cannot reproduce the broken permalinks @frcroth

abc013 commented 2 months ago

Poll pages still seem to have the old layout in the smartphone version

SilvanVerhoeven commented 2 months ago

Abbreveations overlay button

Opened #587 for this

Look like the icons are cut off at the edges

This varies depending on screen size, resolution and browser. This is probably not an issue introduced by this PR

SilvanVerhoeven commented 2 months ago

Poll pages still seem to have the old layout in the smartphone version

Opened #588 for this