search

fsr / ifsr_course_enrollment

Other
3 stars 2 forks source link

Do not hardcode the sender email address #17

Open fer-rum opened 9 years ago

fer-rum commented 9 years ago

At the moment the system sends its mails from a hardcoded mail address as seen in _ViewParticipants.py, line 272. This is no good idea since it seems to override the settings made in settings.py.

kiliankoe commented 9 years ago

Or go with something more reasonable like courses@ifsr.de. At least in the short term.

kiliankoe commented 9 years ago

Just as a question: According to the settings.py the server authenticates itself to the gmail server as ifsrcourses2@gmail.com. So not only is it using gmail, but also using a wrong address helping the mail being thrown right into the user's spam? That just seems overly... awkward.

Or I'm mistaken and the settings just make no sense and are completely overridden elsewhere.

fer-rum commented 9 years ago

I truely do not know. This should be fixed either case. Can you find out, how the mailing exactly works?