search

fsschneider / DeepOBS

DeepOBS: A Deep Learning Optimizer Benchmark Suite
MIT License
103 stars 34 forks source link

Imdb lstm problem #12

Open prabhuteja12 opened 5 years ago

prabhuteja12 commented 5 years ago

Hi, This pull request is to include the IMDb LSTM sentiment classification task (from https://arxiv.org/abs/1910.11758 ) I've added the dataset, network architecture, and I've tested it with the example code in the examples/runner_momentum_pytorch.py as a sanity check.

fsschneider commented 5 years ago

That is great, thank you so much. I hope in a few days I have some time to merge it.

I want to add a "contributors" section to the readme. Would it be okay with you if I added you (and possibly your co-authors) to this list? I want to make sure I properly acknowledge you for contributing.

prabhuteja12 commented 5 years ago

Sure., You can add me (@prabhuteja12) @florianmai as contributors.

There seem to have been some checks failed. Should I send another pull request fixing them?

fsschneider commented 5 years ago

Thanks, I will. Don't worry about the checks. They are currently not perfectly set up and alert on some false positives. I will fix this. Thanks again for your contribution.

prabhuteja12 commented 4 years ago

Hi, I accidentally made a few changes to my rep and it resulted in an update to the pull request. I think i've fixed the accidental errors induced.