search

fsspec / GSoC-kechunk-2022

MIT License
2 stars 2 forks source link

Update example notebooks #3

Closed peterm790 closed 2 years ago

peterm790 commented 2 years ago

The methods used to start clusters on the original 'ike' notebook examples did not work on the esip jupyter lab. These notebooks have been updated to match the methods used in other examples

rsignell-usgs commented 2 years ago

@peterm790, please strip the output of the notebook first -- that way we can see what actually changed in the code.

nbstripout is a helpful tool to do this.

martindurant commented 2 years ago

The easy way to do that without installing the nbstrip tool or any pre-commit thing, is to open the notebook in jupyter and clear all output - It think in the edit menu.

peterm790 commented 2 years ago

I have added another commit with the notebook outputs stripped, I ended up using the nbstripout tool. However I'm not sure if you can see the diffs from the original to the second commit?

rsignell-usgs commented 2 years ago

@peterm790 , indeed, because there are notebooks currently in the main branch with output, if you submit a PR with output stripped, you won't easily be able to see the changes. But once all latest committed notebooks in main have output stripped, future PRs with stripped notebooks should work nicely. So I'll merge this PR.