Open giacomorebecchi opened 10 months ago
I’ve wanted this also, but the __init__
method is already complicated. Can you think of a way to do this nicely without complicating the signature (much) more?
On Dec 27, 2023, at 6:19 AM, Giacomo Rebecchi @.***> wrote:
I'm using adlfs to read and write files from/to Azure Blob Storage, both using a Shared Key and a Shared Access Signature. I'm testing my code using an azurite local container, and when I test access using a SK, I can pass the whole connection string and the AIOBlobServiceClient gets correctly initialized, using as Blob endpoint the localhost. If I want to test the SAS authentication method, passing a sas token, there is currently no way in adlfs to specify a custom account_url, as it is directly computed in the do_connect method.
I would like to propose a PR exposing the account_url kwarg in the init of the class, please let me know if it makes sense!
— Reply to this email directly, view it on GitHub https://github.com/fsspec/adlfs/issues/450 or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKAOIVPXP5APQASZJX6JC3YLQG3ZBFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44SQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJRGA4TIMBRHE4TTAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDEMBVG4ZTAOBSGQ3KO5DSNFTWOZLSUZRXEZLBORSQ. You are receiving this email because you are subscribed to this thread.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
I'm using
adlfs
to read and write files from/to Azure Blob Storage, both using a Shared Key and a Shared Access Signature. I'm testing my code using anazurite
local container, and when I test access using a SK, I can pass the whole connection string and the AIOBlobServiceClient gets correctly initialized, using as Blob endpoint thelocalhost
. If I want to test the SAS authentication method, passing a sas token, there is currently no way inadlfs
to specify a customaccount_url
, as it is directly computed in thedo_connect
method.I would like to propose a PR exposing the
account_url
kwarg in the init of the class, please let me know if it makes sense!