sign: fix expiration time value

fsspec / gcsfs

Pythonic file-system interface for Google Cloud Storage

http://gcsfs.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

320 stars 141 forks source link

sign: fix expiration time value #613

Closed shcheklein closed 3 months ago

shcheklein commented 3 months ago

According to this expiration time if passed as an integer is interpreted as "point in time" not as delta. timedelta could be used instead.

shcheklein commented 3 months ago

@martindurant please let me know if there is anything else missing here. It would be nice to merge and release (let me know if help is needed) since otherwise sign is completely broken it seems.