search

fsspec / gdrivefs

Google drive implementation of fsspec
BSD 2-Clause "Simplified" License
38 stars 20 forks source link

Fix: Pagination #31

Closed k4rth33k closed 2 years ago

k4rth33k commented 2 years ago

The pagination should stop only when the nextPageToken field is missing and the incompleteSearch is False Fixes #30

martindurant commented 2 years ago

That was fast! I wonder if we can figure out a decent way to test in this repo...

martindurant commented 2 years ago

Am I right in thinking that maybe the nextPageToken alone might be what we want?

k4rth33k commented 2 years ago

Yes. Given that we cannot do much with the incompleteSearch field other than re-trying, the intented behaviour can be implemented just with the nextPageToken alone. I think we can go for this change.

martindurant commented 2 years ago

OK like this?

k4rth33k commented 2 years ago

@martindurant :+1: