search

fsspec / sshfs

sshfs - SSH/SFTP implementation for fsspec
Apache License 2.0
58 stars 14 forks source link

Add _cat_file #45

Closed kephale closed 6 months ago

kephale commented 6 months ago

Howdy folks, sshfs is amazing. Thank you for everything!

I was trying to use it for remote visualization of zarr images. This required support for _cat_file. This PR provides a _cat_file implementation.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.10%. Comparing base (c127831) to head (607ce56).

:exclamation: Current head 607ce56 differs from pull request most recent head 8202cf1. Consider uploading reports for the commit 8202cf1 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## ========================================== + Coverage 94.00% 94.10% +0.10% ========================================== Files 13 13 Lines 701 713 +12 ========================================== + Hits 659 671 +12 Misses 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shcheklein commented 6 months ago

@martindurant @efiop PTAL and merge if it looks good (I don't have access to this repo).

martindurant commented 6 months ago

LGTM

@efiop , what are your plans for maintenance of this repo? Are you still available for making releases?

efiop commented 6 months ago

@martindurant I've set up everything in the past to work even if I get hit by a bus :) Just for the record, one could just go to https://github.com/fsspec/sshfs/releases and click release, gha will do its magic 🙂 Triggered 2024.4.0 for now. As to maintaining, I am keeping an eye, but obviously no promises on the reaction time.

efiop commented 6 months ago

Also added @shcheklein to admins here.