search

fsstudio-team / ZeroSimROSUnity

Robotic simulation in Unity with ROS integration.
https://roboticsimulationservices.com/
MIT License
168 stars 21 forks source link

Import does not fetch git lfs files #11

Closed rendellc closed 3 years ago

rendellc commented 3 years ago

When creating a new project, the import does not fetch lfs files. This causes several error messages, which I have pasted below for searchability. Opening the files, for instance Runtime/Scripts/Sensors/RGBDepthCamera/calibration_chessboard.png, in a text editor it is clearly a git-lfs file.

version https://git-lfs.github.com/spec/v1
oid sha256:36a04f9701b424550dbff7cf8c4e5cd7a12e68cea45a98774285af7799492254
size 62550

Looking at Unity git guide, I would expect this to be handled by Unity so I am not sure what causes this issue. It may be a system configuration issue on my end.

System:

Temporary workaround

  1. Add package manually by cloning repo into unity project.
  2. Run git lfs fetch --all and git lfs checkout . to retrieve the lfs files.

Some of the error messages

Library/PackageCache/com.fsstudio.zerosim@cfa659082a/Runtime/Scripts/Util/Docker/ZODocker.cs(9,7): error CS0246: The type or namespace name 'Docker' could not be found (are you missing a using directive or an assembly reference?)
Could not create asset from Packages/com.fsstudio.zerosim/Runtime/Scripts/Sensors/RGBDepthCamera/calibration_chessboard.png: File could not be read
ImportFBX Errors:
Couldn't read file /home/rendell/UnityProjects/ZeroSim test/Assets/Samples/ZeroSim/0.1.15/ZeroSim samples/Assets/Models/Table.fbx.
micahpearlman commented 3 years ago

That is odd. Haven't run across that and we have had quite a number of users. Can you see if there is a difference from using the SSH URL git@github.com:fsstudio-team/ZeroSimROSUnity.git and the HTTPS URL https://github.com/fsstudio-team/ZeroSimROSUnity.git?

rendellc commented 3 years ago

Using https://github.com/fsstudio-team/ZeroSimROSUnity.git gives the same results. It is likely a configuration issue on my end. I will retry on another computer with another Unity setup

rendellc commented 3 years ago

Closing issue as I got it to work now. I had to set some lfs settings manually. Don't think all these settings are relevant, but my current settings are (obtained by git config --list).

lfs.dialtimeout=90
lfs.tlstimeout=90
lfs.batch=true
lfs.contenttype=0
filter.lfs.process=git-lfs filter-process
filter.lfs.required=true
filter.lfs.clean=git-lfs clean -- %f
filter.lfs.smudge=git-lfs smudge -- %f
florianfhws commented 2 years ago

For me unity throws Error when executing git command. git@github.com: Permission denied (publickey). fatal: Could not read from remote repositor when using git@github.com:fsstudio-team/ZeroSimROSUnity.git however with https://github.com/fsstudio-team/ZeroSimROSUnity.git it works fine