search

fstercq / freepybox

Manage your freebox in Python using the Freebox OS API
23 stars 31 forks source link

Avoid importing freeboxpy from setup.py to fix install error #1

Closed stilllman closed 6 years ago

stilllman commented 6 years ago

Trying to install freepybox with pip fails with a "ModuleNotFoundError" if "requests" is not installed yet. This is due to the import of freepybox in setup.py, wich triggers the import of "requests" before it has been installed through the install_requires.

I changed the setup.py to read the version number directly from init.py, without importing, as is done in the setup.py of pip.

stilllman commented 6 years ago

Made the pull request from the wrong branch, creating a new one.