search

fstiewitz / build-tools-cpp

Build your projects in atom
https://atom.io/packages/build-tools
MIT License
31 stars 6 forks source link

Add modelsim profile #28

Closed go2sh closed 8 years ago

go2sh commented 8 years ago

Hi there,

i wrote a modelsim profile to parse vcom and vlog error. I find it very useful and i want to share it with you.

Regards, Chris

fstiewitz commented 8 years ago

Hi Chris, Unfortunately it is missing a spec. I created a wiki to give you some info on how to add one to spec/profile-spec.coffee. I could create the spec myself if I had any idea how these errors look like. I can guess the format based on the regular expressions you provided but it would be better if I had a real example. Other than that your code looks good :+1:

go2sh commented 8 years ago

Hi Fabian, I will add the spec tomorrow. Maybe it's a good idea to split the spec in separate files to keep it clean and handy. BTW: Thanks for that awesome package. I really appreciate your work, especially the connection with the linter package is so great. It speeds up my development process really good. Viele Grüße, ;-) Chris

go2sh commented 8 years ago

Hm the tests are failing, because it doesn't find the language-vhdl package. Its a non standart package, so maybe it has to be installed by hand.... o_O

fstiewitz commented 8 years ago

Right, this is the first profile that requires a non-core package, but this is not a problem of your code. If the specs work with these language packages I'll merge your profile and fix the specs later. Speaking of which, I get 6 failures when I run the specs on my machine but they're all minor errors (your start and end values of the file checks are off by 1). Can you fix those ? (To run specs execute apm test in the package's root folder)

go2sh commented 8 years ago

Now the tests pass with language-vhdl and language-verilog installed. :smile:

fstiewitz commented 8 years ago

Travis CI seems to have problems with their infrastructure but I tested it and the specs run perfectly. Nice job and dankeschön :smiley: