search

fstiewitz / build-tools-cpp

Build your projects in atom
https://atom.io/packages/build-tools
MIT License
31 stars 6 forks source link

Fix modelsim regex #71

Closed go2sh closed 7 years ago

go2sh commented 7 years ago

Somehow the regex does not work any more. Removing the newline char fixes the problem.

fstiewitz commented 7 years ago

I wonder why though, the specs still seem to work (that failure in Travis CI is caused by something else).

go2sh commented 7 years ago

I have no idea. I just recognized that after some update then profile wasn't showing up any more under windows. I don't now weather this is related?

fstiewitz commented 7 years ago

Did errors not get highlighted or did the profile not show up in the settings page? I'm wondering how this $ could have caused a problem. Other profiles use it as well and they work fine.

go2sh commented 7 years ago

Just no highlighting including file detection, line detection, error detection and message.

fstiewitz commented 7 years ago

Well I don't understand why (yet), but the $ is a bit redundant anyway 😄 Thanks for the contribution.

go2sh commented 7 years ago

Awesome work. Keep it up. I have create some more profiles and use build-tools every day. :-)