search

fstiewitz / build-tools-cpp

Build your projects in atom
https://atom.io/packages/build-tools
MIT License
31 stars 6 forks source link

ISSUE: Atom Notification Info #81

Closed cyberea closed 5 years ago

cyberea commented 7 years ago

Hello,

I have been encountering an issue whereby the info notification would not render correctly upon loading up Atom.

I thought I would wait as normally version updates tend to squash these thing for me, but nothing really happened for some time. So I decided to investigate.

ISSUE

build-notification-issue

FORKED BRANCH

https://github.com/cyberea/build-tools-cpp/commit/67d1508f73e19ad603a8a61a27d859bce867c768

I didn't want to submit a PR without writing at least something here first, because it might just be my current Atom setup. Nevertheless, the branch is there if you feel its legit.

Thanks! :)

LeastSignificantBit commented 5 years ago

In addition to cyberea@67d1508 fix, the following &:hover { section seems to cause problems. I removed it and all works well now.

fstiewitz commented 5 years ago

Sorry for not replying. I kinda stopped using atom long ago, so this repo is low priority for me. If you submit a PR I'd apply it :)

LeastSignificantBit commented 5 years ago

Ok, done https://github.com/fstiewitz/build-tools-cpp/pull/85#issue-270627912