search

fstirlitz / luaparse

A Lua parser written in JavaScript
https://fstirlitz.github.io/luaparse/
MIT License
459 stars 91 forks source link

5.2 #35

Closed sauvainr closed 8 years ago

sauvainr commented 8 years ago

I think the best is to create a new "5.2" branch and keep all version separated.

Can you help to create this branch and I ll change the PR target.

fstirlitz commented 8 years ago

I disagree. The different versions of Lua are still close enough to each other not to need this. Having a different branch for each Lua version would only increase the maintenance burden. The parser still has a few issues that need to be addressed (for example, #24 is handled by a quite ugly hack right now), and having to address them three times would be a waste of time.

Besides, the parser already contains support for goto and bitwise/integer division operators, both of which are absent in 5.1. If you were sufficiently pedantic about it, you'd have to remove the latter too.

I think the luaVersion option is a better approach.