search

fstirlitz / luaparse

A Lua parser written in JavaScript
https://fstirlitz.github.io/luaparse/
MIT License
456 stars 93 forks source link

Upgrade the build environment #66

Open fstirlitz opened 5 years ago

fstirlitz commented 5 years ago

This project has hardly been very keen at keeping up with the Kardashians latest developments in the JavaScript world. As a result, the testsuite has experienced some failures as of late. In particular, the spec repository referred to on the depencency list has disappeared from GitHub; as a stop-gap measure, I switched to version 1.0.1 from npmjs.

An overhaul of the build process is probably long overdue. Suggestions are welcome on how to replace deprecated packages without breaking everything and rewriting the project from scratch.

oxyc commented 5 years ago

If we drop support of all the obscure environments and runtimes it wouldn't be that be many manually written tests that need that need to be changed if we switched to whatever library. Most of the tests are scaffolded anyways

teoxoy commented 5 years ago

Looks like #72 is failing because PhantomJS doesn't support ES6... Can we drop support for PhantomJS? It's no longer maintained.

fstirlitz commented 4 years ago

I think I will drop PhantomJS… and replace it with duktape. It may take some time to set it up under Travis CI, however, so I won't be doing it right away.

fstirlitz commented 4 years ago

The more important issue is what to do with spec, however. It is still available from npm and still works, but I don't think it's wise to rely on an unmaintained dependency that may disappear any time soon.

teoxoy commented 4 years ago

You could switch spec for jest or mocha

fstirlitz commented 4 years ago

I upgraded some build dependencies and as of 626f3e4ee6882dd83b8a2b51a6e2c8ecc274840a I managed to shut up npm audit at least. That has to count for something. The issue is still unresolved, though.