search

fstl-app / fstl

A fast STL file viewer
448 stars 105 forks source link

Mymaster enhanced icons #105

Closed wdaniau closed 1 year ago

wdaniau commented 1 year ago

Hi, this pull request might be a little too much to be accepted ;-). By the way, it contains the pending #101 (which adresses #40) and #102 . This also adresses #74. This is my current version, and the way I like to use it. It is available as an ubuntu package fstl-e under ppa:wdaniau/custom . An AppImage and a Windows binary can also be found in the releases on my github fork.

screenshot_fstl-e_20230205

I have added a toolbar as I usually find this easier to use than searching the menus. I also changed all the shortcuts to simple "one key" shortcuts : Q : Quit O : Open R : Reload P : Draw Mode Settings (P comes from Preferences) A : Draw Axes M : Show/Hide Menu (and Toolbar as well) S : Save Screenshot F : Toggle Fullscreen W : Toggle wireframe on top of new shader (see below)

Left : load previous stl file Right : load next stl file Up : Use next shader Down : Use previous shader ( The last two adresses #89 )

I also added a menu with some predefined viewport sizes to help saving screenshots of a given size.

Also added an option in the new shader to draw wireframe on top of it ( adresses #95 ). screenshot_fstl-e_20230212

Save and restore hide menu state ( adresses #90 )

Will.

DeveloperPaul123 commented 1 year ago

Thank you for proposing this, but as you speculated, this PR is a bit too large to merge. If you want to propose PRs for individual features that is more feasible IMO.

I think I'd like to create a shortcut system as well as a shader plugin system which will address some of the features you have included in this PR.