search

fstl-app / fstl

A fast STL file viewer
449 stars 105 forks source link

folder navigation #38

Closed phreaker0 closed 5 years ago

phreaker0 commented 5 years ago

This PR adds the ability to switch between stl files in the current loaded file folder by using the left and right arrow key.

mkeeter commented 5 years ago

Looks good to me, and works fine on Mac. What OS did you test this on, just for completeness?

phreaker0 commented 5 years ago

@mkeeter Linux:

$ lsb_release -a
LSB Version:    core-9.20170808ubuntu1-noarch:security-9.20170808ubuntu1-noarch
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.1 LTS
Release:    18.04
Codename:   bionic
DeveloperPaul123 commented 5 years ago

Tested on windows as well 👍 2018-10-20_16-21-04

mkeeter commented 5 years ago

Cool, looks good.

Out of curiosity, how many STLs did you need in a folder before the insertion-style list-construction was a noticeable speedup?

phreaker0 commented 5 years ago

I didn't test it out before but it bothered me that it was not as fast as it could be :-) As your title says "fastest stl viewer", so this should also be true for the navigation part. I just did a quick and dirty speed test with 10000 stl files in the folder: sort list after it was built: 111 057 796 ns _ sorted insert: 59 608 720 ns