Escape key to close window

fstl-app / fstl

A fast STL file viewer

449 stars 105 forks source link

Escape key to close window #42

Closed zdavkeos closed 5 years ago

zdavkeos commented 5 years ago

Pressing Escape closes the application.

mkeeter commented 5 years ago

This seems like a strange choice, as there are standard platform shortcuts to closing a window (e.g. Command+Q on Mac). I'd recommend against merging, but am open to hearing why this is a desirable feature.

zdavkeos commented 5 years ago

@DeveloperPaul123 I'm not altogether that familiar with Qt, if QCoreApplication::exit(0) is better then that's fine.

@mkeeter I frequently use fstl to spot-check stl files, hitting escape is just quicker for those situations than Alt-F4. I have no strong opinion as far as the product goes - it works well for my use case so I thought I'd share.

DeveloperPaul123 commented 5 years ago

@mkeeter Thoughts ^?

mkeeter commented 5 years ago

One design principle for fstl (vs something more minimal like modelview) is looking and feeling native, so let's stick with the default shortcuts.

DeveloperPaul123 commented 5 years ago

Agreed 👍