search

fstl-app / fstl

A fast STL file viewer
449 stars 105 forks source link

Fix https://github.com/mkeeter/fstl/issues/57 #58

Closed fake-name closed 3 years ago

fake-name commented 3 years ago

Disable annoying warning.

See https://github.com/mkeeter/fstl/issues/57

If this is legitimately a issue with some software out there, a non-modal way of alerting would be OK, just don't pop up a dialog EVERY time I open a file.

mkeeter commented 3 years ago

This is an issue with other software out there: here's a thread calling out Solidworks specifically and listing several tools that break if solid is the first word in the binary header (also this and this).

Still, I think it's fair to declare this "not fstl's problem" and remove the warning. I've fixed it in 78d0c9266c9ca897a7148093888a9620f28fc37b, removing the whole code-path rather than just commenting out this check.

fake-name commented 3 years ago

Awesome!

This is an issue with other software out there

Yeah, but that software is the stuff that's broken. From the original STL specification, this is a invalid heuristic.