search

fsulib / website-refresh-issues

A repository to keep track of our website refresh backlog
0 stars 0 forks source link

Card Components Missing Heading #70

Open jessicapple opened 1 year ago

jessicapple commented 1 year ago

Ruben informed me that the Card Components still use the heading even if that field is left empty of text. Maybe we just need to make it a required field?

jessicapple commented 1 year ago

It turns out that it is actually any empty heading. So the Hero and Card components

barsenault-fsu commented 1 year ago

Card heading appears to have been fixed on March 9 https://github.com/fsulib/fsu_strata_mercury_editor/commit/d126e8443bccc860c7077569ac0742dc57d1ad9b

Added similar check so that heading is only added of there is heading text https://github.com/fsulib/fsu_strata_mercury_editor/commit/ed75cdae897a8720ecff1e936dc70c8f9dd9dafa

Will need to get deployed to test and production