✨ De-caddifies and re-Origamifies nightingale-charts - Githubissues

ft-interactive / nightingale-charts

FT style charts, axes, scales etc

http://ft-interactive.github.io/nightingale-charts

12 stars 5 forks source link

✨ De-caddifies and re-Origamifies nightingale-charts #152

Open aendra-rininsland opened 7 years ago

aendra-rininsland commented 7 years ago

Removes web-caddy :raised_hands:
Adds Origami Build Tools
Changes the examples to Origami demos
Removes object-assign and Function.prototype.bind polyfills (now provided via Polyfill service)
D3 is now consumed via npm and not Bower
~npm-prepublish is now used to publish packages~ (This is now in #155)
Entry point moved from src/scripts/nightingale-charts.js to main.js in repo root
Styles entry point moved to main.scss in the repo root

This will resolve #148 and #67 and paves the way for #77 and #78 given OBT provides Babel transpilation.

aendra-rininsland commented 7 years ago

Still to do:

[ ] Possibly remove Regression tests (no longer used?)
[ ] Get functional tests to pass
[ ] Double-check that unit tests aren't throwing false positives

To make into an Origami component:

[ ] Rename to o-charts
[ ] Move repo to financial-times GitHub org
[ ] Merge in #155 (optional?)
[ ] Merge in #153