Closed lc512k closed 6 years ago
This project's in really good shape a11y-wise π
I've only added some minor fixes:
<H6>
_blank
#void
a11y:local
One thing I would strongly suggest is removing the --threshold argument in https://github.com/ft-interactive/starter-kit/blob/master/package.json#L85-L86 but have left that to you, as these would mean the build fails if there's a single error, similar to the qa tests
--threshold
This template currently passes pa11y and has 0 errors in HTMLCodeSniffer
Pleasure! Thank you for having me, @joannaskao!
This project's in really good shape a11y-wise π
I've only added some minor fixes:
<H6>
s from the footer_blank
targets#void
from copyright href and replaced with dummy url. Leaving#void
in accidentally would cause a wcag violationa11y:local
script to run a11y checks locally manuallyOne thing I would strongly suggest is removing the
--threshold
argument in https://github.com/ft-interactive/starter-kit/blob/master/package.json#L85-L86 but have left that to you, as these would mean the build fails if there's a single error, similar to the qa testsThis template currently passes pa11y and has 0 errors in HTMLCodeSniffer