ft-interactive / starter-kit

A template for IG pages
65 stars 15 forks source link

A11y #171

Closed lc512k closed 6 years ago

lc512k commented 6 years ago

This project's in really good shape a11y-wise πŸ‘

I've only added some minor fixes:

One thing I would strongly suggest is removing the --threshold argument in https://github.com/ft-interactive/starter-kit/blob/master/package.json#L85-L86 but have left that to you, as these would mean the build fails if there's a single error, similar to the qa tests

This template currently passes pa11y and has 0 errors in HTMLCodeSniffer

lc512k commented 6 years ago

Pleasure! Thank you for having me, @joannaskao!