ft-interactive / starter-kit

A template for IG pages
65 stars 15 forks source link

Updating CircleCI config to be faster #200

Closed aendra-rininsland closed 5 years ago

aendra-rininsland commented 6 years ago

This does a few things:

  1. Removes some of the weird caching behaviour Callum added to counter some of the bugs in early versions of CircleCI v2
  2. Uses npm ci to install exact deps using package-lock.json
  3. Removes the apt-get install step, instead using the Dockerfile here

As a result CircleCI builds should be much, much faster.

N.b., the Docker image I'm using is aendrew/starter-kit-docker:latest — I've namespaced it to my Docker/GitHub users because there's neither a Financial Times Dockerhub user nor one for ft-interactive. I figure I'll move the image and everything there eventually if and when those get created.

aendra-rininsland commented 6 years ago

Build time perf improvement:

I've moved npm cache to ~/.npm and made npm updating part of the base image:

aendra-rininsland commented 5 years ago

Let's not do this for the immediate future.