ft-interactive / starter-kit

A template for IG pages
65 stars 15 forks source link

V2 [work-in-progress] #204

Closed aendra-rininsland closed 4 years ago

aendra-rininsland commented 6 years ago

Okay, lots of stuff going on here.

joannaskao commented 6 years ago

How would we change the default layout in individual projects if we wanted to (e.g. add another social button, center the headline, etc...)? I wonder if a commented out example would be helpful.

joannaskao commented 6 years ago

Can we still use the Origami build service? Where would we add that in?

aendra-rininsland commented 6 years ago

@joannaskao —

re: Origami Build Service deps, that's currently hardcoded in g-components. Will make configurable

re: modifying the default layout, it can be done by replicating g-components/Layout and overriding individual components. As g-components matures, more customisation will be possible without having to replicate individual components, though in general it's kind of designed to prevent non-standard design decisions without a bit of work.

maxharlow commented 6 years ago

The more I think about it the more I really like the separate g-components -- I think it's a much better structure. Which made me think -- are there any more parts we could move out into separate, versioned releases? Would be great if the only code you got with Starter Kit was code that you would be very likely to modify -- like client/app.js, config/index.js, etc.

I think the advantages of this approach would be:

I'm imagining a fresh future Starter Kit project being just a few files -- one with the main body content, one setting up the build, a config file, a package.json (with just a couple dependencies on g-components, and other g- things), as well as a few dotfiles.

One candidate would be the Webpack build -- could that potentially be pulled out into a g-builder repository? A default Starter Kit project could then have package.json scripts that call it.

What do you think? Good idea?

aendra-rininsland commented 6 years ago

@maxharlow I do quite like that idea, I think we talked briefly last week about creating something that works similar to create-react-app that can be saved as a dependency and then ejected if necessary. I'm inclined to sort that out sooner rather than later to benefit most from all the shared dependencies.

aendra-rininsland commented 4 years ago

Closing and renaming branch to master 🎉