Do SSR with Puppeteer at build-time instead of with JSDOM *every refresh*

aendra-rininsland commented 5 years ago

The hope with this is that we can stop doing stupid hacky shit in order to ensure JSDOM is able to render things. This should also dramatically speed up the DX because it'll help HMR to work better.

Issues to resolve:

[x] Whatever sets html.core to html.enhanced doesn't seem to be firing
[x] o-comments doesn't seem to be working in dev builds (see above).
[x] app/index.js currently doesn't pass linting
[x] CI is failing because of running as root with --no-sandbox. Might need to use a CircleCI image.
[x] HMR isn't working for JS
[ ] ~HMR isn't working for CSS~ Forget it. 🙄

aendra-rininsland commented 5 years ago

o-comments is actually working; you just need to specify title, url and UUID. Title should be derived from headline if not present, see financial-times/g-components#29.

aendra-rininsland commented 5 years ago

HMR is actually working really well now! Unfortunately sass-loader's HMR support is still garbage.

Can we please just stop using Sass? ...Please?

ft-interactive / starter-kit