ft-interactive / starter-kit

A template for IG pages
65 stars 15 forks source link

Do SSR with Puppeteer at build-time instead of with JSDOM *every refresh* #242

Closed aendra-rininsland closed 5 years ago

aendra-rininsland commented 5 years ago

The hope with this is that we can stop doing stupid hacky shit in order to ensure JSDOM is able to render things. This should also dramatically speed up the DX because it'll help HMR to work better.

Issues to resolve:

aendra-rininsland commented 5 years ago

o-comments is actually working; you just need to specify title, url and UUID. Title should be derived from headline if not present, see financial-times/g-components#29.

aendra-rininsland commented 5 years ago

HMR is actually working really well now! Unfortunately sass-loader's HMR support is still garbage.

Can we please just stop using Sass? ...Please?