search

ft-interactive / starter-kit

A template for IG pages
64 stars 15 forks source link

Another refactor re: Vike v1 #347

Closed aendra-rininsland closed 1 month ago

aendra-rininsland commented 2 months ago

Should probably fix financial-times/g-components#263 before merging.

pandringa commented 2 months ago

Thanks for doing all of this work - I've been meaning to tweak this but haven't had time yet.

My only question is - should we be using the official vike-react extension rather than doing our own? It seems like if we use theirs, it will automatically configure the onRenderHTML and onRenderClient for you, and add a bunch of extra options around <head> tags, data fetching, etc: https://vike.dev/vike-react

It might require a more extensive refactor, so if it seems like a lot of work perhaps we'll stick with the existing version. (I'll poke around in the next few days and, if it seems like a good idea, open a PR against this one with the suggested changes!)