search

ft-interactive / visual-vocabulary-templates

Library of chart templates based on the visual vocabulary
http://ft-interactive.github.io/visual-vocabulary-templates/
77 stars 11 forks source link

Should be exportable to NodeJS #121

Closed aendra-rininsland closed 6 years ago

aendra-rininsland commented 6 years ago

Currently the .plotdim() method is a shortcut for returning the window.plotdim global. The window global variable is unavailable in NodeJS and other contexts, meaning bundling charts into other tooling is currently impossible.

aendra-rininsland commented 6 years ago

I've fixed this in financial-times/vv by using Webpack's ProvidePlugin and setting window.plotDim to []. Thus no upstream change is required.