search

ft-interactive / visual-vocabulary-templates

Library of chart templates based on the visual vocabulary
http://ft-interactive.github.io/visual-vocabulary-templates/
77 stars 11 forks source link

Allow for minor ticks to be set to false on line-vertical template #144

Closed joannaskao closed 6 years ago

joannaskao commented 6 years ago

Setting minor ticks to false creates an error

bobhaslett commented 6 years ago

This is because there is a transition on the minor axis at line 210 in the index. When the minorAxis is set to false there is no object to transform, which throws the error. I've made the transform conditional on the minorAxis variable being set to true which seems to have sorted it,