search

ft-interactive / visual-vocabulary-templates

Library of chart templates based on the visual vocabulary
http://ft-interactive.github.io/visual-vocabulary-templates/
77 stars 11 forks source link

priestley date #148

Closed martinstabe closed 6 years ago

martinstabe commented 6 years ago

x-Axis value extent on Priestley timeline not calculated correctly. Defaults to 1970-01-01 as xMin.

martinstabe commented 6 years ago

… or uses that date as xMax if data contains earlier dates.

martinstabe commented 6 years ago

Works as expected when min and max dates span 1970-01-01.

bobhaslett commented 6 years ago

Can I have the data you are using?

On 30 July 2018 at 13:43, Martin Stabe notifications@github.com wrote:

Works as expected when min and max dates span 1970-01-01.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ft-interactive/visual-vocabulary-templates/issues/148#issuecomment-408849984, or mute the thread https://github.com/notifications/unsubscribe-auth/AEhOMlA2zAxo6ABHS-g-5GgfMHhFormHks5uLv9WgaJpZM4VmU0B .

-- Bob Haslett 4895

--

This email was sent by a company owned by Financial Times Group Limited ("FT Group http://aboutus.ft.com/corporate-information/#axzz3rajCSIAt"), registered office at Number One Southwark Bridge, London SE1 9HL.  Registered in England and Wales with company number 879531. This e-mail may contain confidential information. If you are not the intended recipient, please notify the sender immediately, delete all copies and do not distribute it further.  It could also contain personal views which are not necessarily those of the FT Group.  We may monitor outgoing or incoming  emails as permitted by law.

martinstabe commented 6 years ago

@aendrew has solved: xMin and xMax need to be convented to epochal times — in miliseconds

maxharlow commented 6 years ago

ximin and amx values are now passed to a date parser