search

ft-interactive / visual-vocabulary-templates

Library of chart templates based on the visual vocabulary
http://ft-interactive.github.io/visual-vocabulary-templates/
77 stars 11 forks source link

Fix boxplot #171

Closed alansmithy closed 5 years ago

alansmithy commented 5 years ago

The boxplot seems to have been calculated with mean as the central measure rather than the median. This PR addresses that

bobhaslett commented 5 years ago

Just had a look at this and the central measure is the second quantile, q2. The mean is there, but it is a user option to turn on and off if you want. Lines 57-58 in boxplot.js draw the median line. Lines 61-60 conditionally draw the mean line. If everyone is happy this is OK I'll cancel the pull request

alansmithy commented 5 years ago

Just had a look at this and the central measure is the second quantile, q2. The mean is there, but it is a user option to turn on and off if you want. Lines 57-58 in boxplot.js draw the median line. Lines 61-60 conditionally draw the mean line. If everyone is happy this is OK I'll cancel the pull request

Bob - that's great, thanks for checking . I think we should take the mean out completely - it's not something we'd be likely to be using as standard on a plot like this and it might lead to implementation problems if people see it as an option. So - suggest we cancel the PR and then simply remove the mean element as a follow-up