Open rkunze opened 7 years ago
Would it perhaps make sense to integrate the functionality of the about app into this new update app? It's already dealing with system versions and licenses.
Some days ago you said it make more sense splitting functionalities is different apps. So I would prefer to split this into two apps.
Raphael
Till Harbaum notifications@github.com schrieb am Fr., 3. März 2017, 22:01:
Would it perhaps make sense to integrate the functionality of the about app into this new update app? It's already dealing with system versions and licenses.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ftCommunity/ftcommunity-TXT/issues/78#issuecomment-284069045, or mute the thread https://github.com/notifications/unsubscribe-auth/AQa6kRW0npkKNmjImrWPOT9LL6IOX0CXks5riH-5gaJpZM4MSuts .
No, I don't think we should integrate "Update" and "About", even if both apps deal with firmware versions and display information — the functionality is too different: "About" tells the user what is currently installed (i.e. it only displays information), and "Update" installs a new version (i.e it changes the system). I for one would not expect the "Update" functionality in something labelled "About"...
Extending the "About" app to indicate if a new version is available (in the "Firmware" line on the "Versions" page) could be a good idea, though.
Fine for me ... that was just a suggestion.
Such a status bar plugin would import all the qt libraries required to deal with sending http requests. Is the ability to display the update icon really worth the additional load time and memory?
Depends - mainly on how much impact the HTTP stuff really has. Do you have any figures for that?
And do we really need to use the Qt HTTP libs? My plan was to use the "native" HTTP support from python (urllib.request).
I think urllib.request is enough. We just need one request to the Github API.
Raphael
Can anybody check https://github.com/ftCommunity/ftcommunity-TXT/compare/master...ski7777:update-app ? Just the translation is not working and I don't know why
Raphael
Bump!
Just commented on PR#83 https://github.com/ftCommunity/ftcommunity-TXT/pull/83 My understanding is that #83 is not ready because of the blocking behavior of the http request. I would like to close PR83 and leave this issue open. Any objections?
Agreed
I will update https://github.com/ftCommunity/ftcommunity-TXT/compare/master...ski7777:update-app in the next few days, maybe tonight. Then we have an extended update script that helps to check the update progress. The newly introduced update app can show the progress so the user won't interrupt the update progress because he things it's stuck. In normal mode the app can just update to current stable version. If a snapshot version is installed or the app is started with a special argument you can pick from all versions.
Raphael
New discussion here: Do we need an update app? Features? Separate app? Settings app? ...
postponing to 1.1
With the new SD card file system layout introduced in 79e363fc6f8b24b42aa7d2047057c5951620b0fd and the system update script from 8c1f14f4f4ec05cc235e730c54e19afa3eb628b9, we have the necessary functionality for "Over-the-Air" automatic system updates for the community firmware — we just need a launcher status bar plugin that periodically checks if a new version is available, and a GUI app that displays update metadata (version number etc.) and provides an "Install Update" button.