ftao / python-ifcfg

Python cross-platform network interface discovery (ifconfig/ipconfig/ip)
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

minor mistake in doc #12

Closed asteriogonzalez closed 7 years ago

asteriogonzalez commented 7 years ago

I think when you say in the doc

for interface in ifcfg.interfaces:

it must be something like:

for name, interface in ifcfg.interfaces().items():

or

for interface in ifcfg.interfaces().values():

as is a function and returns a dict() instead a list

benjaoming commented 7 years ago

Thanks for reporting this @asteriogonzalez !

Would you be able to submit a PR for this? It would be very helpful :+1: