search

ftao / python-ifcfg

Python cross-platform network interface discovery (ifconfig/ipconfig/ip)
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Fix windows encoding error #16

Closed benjaoming closed 6 years ago

benjaoming commented 6 years ago

Fixes an issue reported here:

https://github.com/learningequality/kolibri/issues/2994

I would like to assert some stuff regarding output of ipconfig on non-English Windows systems before the next release. If the encoding error is fixed but the parsing remains broken, there's still some work to be done...

codecov-io commented 6 years ago

Codecov Report

Merging #16 into master will increase coverage by 1.54%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   84.72%   86.27%   +1.54%     
==========================================
  Files           4        4              
  Lines         203      204       +1     
==========================================
+ Hits          172      176       +4     
+ Misses         31       28       -3
Impacted Files Coverage Δ
src/ifcfg/tools.py 100% <100%> (ø) :arrow_up:
src/ifcfg/parser.py 85.4% <0%> (+2.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 53fc00a...17d73ad. Read the comment docs.