search

ftao / python-ifcfg

Python cross-platform network interface discovery (ifconfig/ipconfig/ip)
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Iproute #32

Closed ljonsson closed 6 years ago

ljonsson commented 6 years ago

Repair the 'ip' interfaces() functionality as well as add default_interface(). Also add default_interface() for OSX.

benjaoming commented 6 years ago

Thanks for the contribution @ljonsson -- I've been working a bit on the tests to make them run on my own dev environment and spotted a minor err in your last test case. Also amended the developer documentation a bit.

codecov-io commented 6 years ago

Codecov Report

Merging #32 into master will decrease coverage by 4.35%. The diff coverage is 46.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   89.09%   84.74%   -4.36%     
==========================================
  Files           4        4              
  Lines         211      236      +25     
==========================================
+ Hits          188      200      +12     
- Misses         23       36      +13
Impacted Files Coverage Δ
src/ifcfg/parser.py 80% <46.66%> (-6.12%) :arrow_down:
src/ifcfg/__init__.py 96.55% <50%> (+3.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b6b6f2f...4b6e9f7. Read the comment docs.