ftao / python-ifcfg

Python cross-platform network interface discovery (ifconfig/ipconfig/ip)
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Extend device name pattern in UnixIPParser #35

Closed ubnt-algardas closed 5 years ago

ubnt-algardas commented 5 years ago

Accept everything except colon when matching device name. Examples that didn't match before: 2: eth-int: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc 7: eth-usb-5@eth-usb: <BROADCAST,MULTICAST> mtu 1500 qdisc noop

benjaoming commented 5 years ago

@ftao this broke the tests, it would be great if linting could be restored!

benjaoming commented 5 years ago

Haha @ftao you already addressed this before my comment, nice! :heart_eyes: