Closed LoyVanBeek closed 4 years ago
Ack, this build now fails because ip
and ifconfig
are not available in the Travis runner :laughing:
Ack, this build now fails because ip and ifconfig are not available in the Travis runner laughing
Tests mock outputs of ip
and ifconfig
, except that there is one set of tests that run on the local system. Since Travis doesn't have the commands, it could make sense to just skip them if they're not there.
The build is failing in the tests test_cp1252_encoding
and test_cp1252_non_utf8_byte
because those run on Windows. The command it trying to run, but that fails because the tests are of course not running on Windows.
That is now patched in the tests for weird windows encodings.
Merging #45 into master will decrease coverage by
1.34%
. The diff coverage is42.85%
.
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
- Coverage 84.68% 83.33% -1.35%
==========================================
Files 4 4
Lines 235 240 +5
==========================================
+ Hits 199 200 +1
- Misses 36 40 +4
Impacted Files | Coverage Δ | |
---|---|---|
src/ifcfg/__init__.py | 90% <33.33%> (-6.43%) |
:arrow_down: |
src/ifcfg/parser.py | 79.19% <50%> (-0.81%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2d6a87f...4359fd2. Read the comment docs.
It's getting more and more messy with the architecture of this project... thinking about how Parser
and get_command
are developing. But I guess everyone can live with this, as long as IPs and interface names are quickly and correctly detected.
Released in 0.20
Fixes #44 Output in case both
ifconfig
andip
are missing is this:First is a warning, raised when the module is imported and the exception is raised when getting
interfaces()