ftao / python-ifcfg

Python cross-platform network interface discovery (ifconfig/ipconfig/ip)
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Relase 0.21 #48

Closed benjaoming closed 4 years ago

benjaoming commented 4 years ago

CC: @ftao @jamalex @indirectlylit @fdellwing

Am wondering about the change from #47 - I ran the tests, and they are fine. Also locally on my machine. And I think this an important change for machines that have a non-English locale. I just don't have a Windows box to test it on.

Any concerns about releasing this?

codecov-io commented 4 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   83.47%   83.47%           
=======================================
  Files           4        4           
  Lines         242      242           
=======================================
  Hits          202      202           
  Misses         40       40
Impacted Files Coverage Δ
src/ifcfg/__init__.py 90% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fbe913a...4172c93. Read the comment docs.

indirectlylit commented 4 years ago

For Kolibri we'd definitely want to test on Windows before deploying the update. Upgrading in develop and waiting for integration tests in 0.14 would be acceptable for us – any issues ought to come out then. Can't speak for other users though.

fdellwing commented 4 years ago

As we are using a common and well tested python method here and not an ugly hack, this will most likely change nothing on windows at all. But I would feel better if some windows project using this, evaluates it first.

benjaoming commented 4 years ago

I propose that we do a 0.21b1 and try it out in a build of Kolibri..

fdellwing commented 4 years ago

Did you forget to publish the beta release?

benjaoming commented 4 years ago

@fdellwing was working from a train :) 0.21b1 released now