search

ftao / python-ifcfg

Python cross-platform network interface discovery (ifconfig/ipconfig/ip)
BSD 3-Clause "New" or "Revised" License
55 stars 37 forks source link

Improvements for Windows #57

Closed egabrum closed 3 years ago

egabrum commented 3 years ago
codecov-io commented 3 years ago

Codecov Report

Merging #57 into master will increase coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
+ Coverage   85.01%   85.13%   +0.11%     
==========================================
  Files           4        4              
  Lines         267      269       +2     
==========================================
+ Hits          227      229       +2     
  Misses         40       40
Impacted Files Coverage Δ
src/ifcfg/parser.py 82.00% <100.00%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21370c6...939d366. Read the comment docs.

egabrum commented 3 years ago

Somewhat related to issue #25

egabrum commented 3 years ago

pinging @ftao

egabrum commented 3 years ago

pinging @benjaoming

benjaoming commented 3 years ago

Hi @egabrum - it seems you added the tests but something went wrong when rebasing the PR?