search

ftctechnh / ftc_app

FTC Android Studio project to create FTC Robot Controller app.
759 stars 3.17k forks source link

Incorrect motor configuration data #713

Closed David10238 closed 5 years ago

David10238 commented 5 years ago

The ticks per rev of RevRobotics40HDHexMotor and RevRobotics20HDHexMotor are twice what they should be RevRobotics40HDHexMotor should be 1120 not 2240 RevRobotics40HDHexMotor should be 560 not 1120

Windwoes commented 5 years ago

Well, assuming that the encoder on the REV HD Hex motor has a 7-pole magnet, it appears you are correct.

Calculations with 40:1 reduction

ChanA cycles per rev at encoder shaft = 7

 7 *  2 = 14    (cycles of A and B)
14 *  2 = 28    (edges of a pulse)
28 * 40 = 1120  (edges * gearbox reduction) --> TOTAL = 1120

Calculations with 20:1 reduction

ChanA cycles per rev at encoder shaft = 7

 7 *  2 = 14   (cycles of A and B)
14 *  2 = 28   (edges of a pulse)
28 * 20 = 560  (edges * gearbox reduction) --> TOTAL = 560
NoahAndrews commented 5 years ago

The REV encoder guide and a quick test confirms that you're correct. I'll submit a PR to get this fixed.

rbrott commented 5 years ago

I know this is probably fixed in the internal repo, but it would be nice to keep the issue open here until it's actually fixed in a release (especially since releases are now few and far between).

cmacfarl commented 5 years ago

I can confirm that it's fixed in v5.0 which will be released within the next couple weeks.

On Sat, Jun 15, 2019 at 12:45 PM Ryan Brott notifications@github.com wrote:

I know this is probably fixed in the internal repo, but it would be nice to keep the issue open here until it's actually fixed in a release (especially since releases are now few and far between).

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ftctechnh/ftc_app/issues/713?email_source=notifications&email_token=AAK6P53R3CKDLIYDPC57ZADP2VBEBA5CNFSM4HVJ2RU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXY64CQ#issuecomment-502394378, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK6P52GQ3VDT7RAE4O7RDLP2VBEBANCNFSM4HVJ2RUQ .

rbrott commented 5 years ago

I understand, but it's still present in the current version. The open issues on this repo are the canonical (and pretty much sole) list of known issues with the SDK. The open public issues should reflect the state of the public SDK not the internal SDK.

rbrott commented 5 years ago

Additionally, it would be nice to have a list of fixed public GitHub issues in the release changelogs (or some kind of milestone/label). It could also help clarify situations like this.