search

ftde0 / yt2009

2009 youtube frontend.
Apache License 2.0
193 stars 119 forks source link

Captions support on youtube mobile apps? #80

Closed mrkrabs206 closed 2 months ago

mrkrabs206 commented 7 months ago

As of now, only the web version of YT2009 allows captions on most videos with captions.

But, there is only one that captions weren't implemented on YT2009, and that's the mobile apps. Like, why this isn't supported yet on these (1.x-4.x)?

I found them in the files and I want to show you some of these.

1.x:

ic_menu_captions Captions button btn_cc_off Captions off btn_cc_on Captions on

2.x: btn_cc_off Captions off btn_cc_off_focus Captions off (pressed) btn_cc_on Captions on btn_cc_on_focus Captions on (pressed)

3.x: ic_vidcontrol_cc_off Captions off ic_vidcontrol_cc_on Captions on

4.x: ic_vidcontrol_cc_off Captions off ic_vidcontrol_cc_on Captions on

It could be great to add this feature to mobile apps to understand the video for deaf people and the people who speak in another language (French, Spanish etc).

This is my last idea to be shared.

Hopefully this will be done.

mrkrabs206 commented 4 months ago

Please @ftde0 it is easy to get captions on mobile too

breakgimme commented 4 months ago

Pull requests are welcome if it's so easy!

mrkrabs206 commented 4 months ago

Pull requests are welcome if it's so easy!

It needs a comparison of the two so it not let me

breakgimme commented 4 months ago

yeah, that's how pull requests work, you compare the upstream code to your code that has the mobile captions implementation

gigigigi53 commented 2 months ago

Any updates? It's been 5 months...

ftde0 commented 2 months ago

i've mentioned this already to you in a different issue. captions would need additional requests which would drastically slow down loading times and the amount of requests made to youtube, which already is quite big.

gigigigi53 commented 2 months ago

i've mentioned this already to you in a different issue. captions would need additional requests which would drastically slow down loading times and the amount of requests made to youtube, which already is quite big.

Maybe in the future it's possible on mobile

gigigigi53 commented 2 months ago

and read issue #128 @ftde0