Potential subtle off-by-one in load_image

fthaler / rawhdr

A simple HDR image merger that converts multiple RAW files into a single HDR image.

https://fthaler.github.io/rawhdr

Other

30 stars 1 forks source link

Potential subtle off-by-one in load_image #5

Closed nullus closed 1 year ago

nullus commented 1 year ago

In load_image, assuming the input data domain is [0, 65535] (i.e. 16-bit integer) then the converted output range is [0, 1) because it's being divided by 65536.

Though it would never be visible, it appeared incorrect to me. I created #4 while experimenting with some other changes

fthaler commented 1 year ago

Good catch and thanks for your contribution! I merged #4.