search

fthx / babar

Task bar. GNOME Shell extension
GNU General Public License v3.0
41 stars 14 forks source link

Add support for GNOME 40 #12

Closed frandieguez closed 3 years ago

frandieguez commented 3 years ago

Hi!

I've quickly reviewed your extension to make it work on gnome-shell 40. The prefs panel didn't start due to some gtk4 deprecations errors.

Note that I've only commented out the conflicting margin property.

I've took the chance to format prefs.js and extensions.js files with https://prettier.io/

fthx commented 3 years ago

Ok thanks! Well, I won't push all that because of all the formatting. But I tried removing the margin line in prefs.js, as you did, and it works. But we have to replace this margin by something-smart-gtk4ish because it does not look nice. I do not have the time to do this now. If you do, I can push a commit for prefs.js changes.

I tried to do something else for app grid button but I have yet to find out what's the new command to show app grid. I did not succeeded with new imports.ui.dash.ShowAppsIcon() instead of the current icon or StBox.

I got some session crashes running Fedora 34, but do not know if it's extension's fault. I feel there is something wrong in workspaces buttons. But I did not find anything in logs that I can use.

fthx commented 3 years ago

https://developer.gnome.org/gtk4/unstable/GtkGrid.html

fthx commented 3 years ago

And I don't know why Places label do not become a pretty icon. Arrows in menus have been removed, but that's not a problem since an option can be easily made to remove them. Let's focus on other parts!

fthx commented 3 years ago

Please use the new dedicated branch: https://github.com/fthx/babar/tree/GNOME40