search

fthx / babar

Task bar. GNOME Shell extension
GNU General Public License v3.0
41 stars 14 forks source link

Fix tooltip artifact when locking screen #16

Closed kenoh closed 3 years ago

kenoh commented 3 years ago

When locking a screen (with a keyboard shortcut) while hovering a BaBar button, the extensions gets destroyed but the tooltip stays on, effectively being orphaned and never getting hidden in the future (even after unlocking the screen).

fthx commented 3 years ago

I could reproduce this.

https://github.com/fthx/babar/commit/0c0655ce6c2b315bb97290216f11e48130b69829 It's better to destroy this tooltip instead of hiding it.

Thanks for the catch!! That is very annoying if it happens.

kenoh commented 3 years ago

Right, I am not skilled with Gnome extensions. But it was annoying enough for me to look for a solution. Thanks! :)

fthx commented 3 years ago

LOL yes, I never experienced this bug before your report, but clearly this persistent tooltip layout was horrible.

If you just hide it, the object does still exist when the extension is disabled and if the extension is enabled again (every screen locking or sleep mode, e.g.), then we have 2 tooltips in the wild. Anyway, apart from the visual glitch, that was a bug as the extension's objects were not correctly destroyed. So that's a double good catch.