search

fthx / babar

Task bar. GNOME Shell extension
GNU General Public License v3.0
41 stars 14 forks source link

Fallback to a window's icon when there is no app icon. #44

Closed rickybrent closed 3 years ago

rickybrent commented 3 years ago

Hello! Thanks for this extension and simple task bar before it.

I've been using this change to fallback to the window icon when the app icon is unavailable on a personal fork for simple task bar and thought it might be worth committing upstream when I ported things over to babar.

fthx commented 3 years ago

Hi,

Thanks for this PR. Do you use this in BaBar since some time ago? Do you have any errors in logs ("fthx", "js")? If it's ok, I'll pull this quickly.

rickybrent commented 3 years ago

Not quite -- I've been using almost this exact method in Simple Task Bar since January, but only switched to babar recently.

I haven't seen any errors about it in the logs (using journalctl /usr/bin/gnome-shell) but will watch carefully.

fthx commented 3 years ago

Ok. Could you bump me in a few days if all is still ok? Then I will try this myself (I do not use BaBar anymore because I use Gnome native setup but still maintain it) then upload in Gnome's website. What Gnome version do you use?

rickybrent commented 3 years ago

Sure thing! (And that's really generous of you, too.)

I use 3.38.4 and 40.4; I'll keep an eye on it on both.

rickybrent commented 3 years ago

Everything looks good -- I know it was more than a few days, but let's call that extra testing time. :)

fthx commented 3 years ago

Thanks! I will upload extension soon... In a few days. :-)