Babar thinks "DING" is a window

[bernardelli]

Firstly, thank you for the simple task bar project and this current remake. I love saving screen space.

I use a extension for better desktop icons, DING. Babar recognizes it as a window at the sticky workspace. Clicking on the right gear below shows/hides the desktop icons.

I am not sure, though, where the left gear comes from. I will try to find out later.

[bernardelli]

Just found out that the first gear only appears when I am using two monitors. But I'm still not sure what's going on.

[fthx]

Thanks for reporting. I look at this now, I think that checking more carefully the windows that have to be shown as icons will solve this. I hope that Looking Glass will tell me what type is DING window.

FYI: The gear is the default fallback icon, if window app does not have one. It's useful too when GS create a window object but its properties are not yet accessible... Would you need a setting for this fallback icon or you don't care?

[fthx]

Ok, done. You can find the commit here: https://github.com/fthx/babar/commit/d3b874ef8d9c81f1f8c479855cceaf4eeb3d3148 You can also download the latest version here, before reviewing by GNOME team: https://extensions.gnome.org/review/download/22315.shell-extension.zip

I just added DESKTOP WindowType in blacklist. And it worked, as far as I can test. Feel free to reopen if it did not solve your issue.

[fthx]

Ok, I saw that you changed icon size and that the gear did not follow that: https://github.com/fthx/babar/commit/bd6033277612e3174e0cadd7d3ccab2bcebdc80b You can find the corrected extension here: https://extensions.gnome.org/review/download/22318.shell-extension.zip

[bernardelli]

The problem is gone! 🎉

[fthx]

FYI: https://github.com/fthx/babar/issues/6#issuecomment-781943033 New options: hide dash & ww thumbnails, buttons for moving window to another ws. I don't know how to make drag'n'drop, so it's better than nothing. :-)

[patarapolw]

Can I choose what to hide?

Currently, I need not only DING, but also Conky.

[fthx]

What is precisely your issue? Conky is displayed as a BaBar icon? If Conky is displayed as a NORMAL typed window, I cannot do anything and this should be considered as a Conky bug.

[patarapolw]

I am only opening Brave browser.

First icon is Conky. It's in Applications also. Third icon is DING; which I didn't use before I tried today...

And DING moves when I change workspace.

Forgot to mention. I am on GNOME 40.

[fthx]

Ok, so something has changed in DING too. I try that in my Fedora 34 VM and I'll be back.

Could you check the window type of Conky (using lg) ?

[patarapolw]

own_window_type = 'normal',

What is lg?

[fthx]

Looking Glass of GNOME Alt+F2, lg

[fthx]

use the pipette

[fthx]

Ok, DING is a NORMAL window (value: 0), so I cannot do anything. Maybe a hack, I'll see.

[patarapolw]

DING disappears in Xorg, but appear in Wayland.

I am currently in Xorg.

[fthx]

Well, it will be hard, because the DING window name is:

[fthx]

So, I think DING has to revert to its DESKTOP typed window. What's the name of conky's window?

[fthx]

Does DING window appear in GNOME Dash?

[patarapolw]

Both GNOME and Conky, no, I think. (In Wayland)

I still hope for a Quick Fix, in extension.js, maybe.

Conky title is conky (<MY_LAPTOP_NAME>)

[fthx]

Hmm, maybe I can investigate on some window properties (fullscreen but not minimizable e.g.) to filter displayed BaBar icons.

[patarapolw]

And, it tried connect a second screen, DING duplicates, with some odd, but different title.

[fthx]

Could you check that for DING and Conky windows? :

[patarapolw]

Top is Conky. The bottom is DING, I think.

BTW, temporary solution.

    // create window button ; ws = workspace, w = window
    _create_window_button(ws_index, w) {
        // windows on all workspaces have to be displayed only once
        if (!w.is_on_all_workspaces() || ws_index == 0) {
            if (/^conky \(.+\)$/.test(w.title)) {
                return
            }

            if (/^@!\d+,\d+;BDH$/.test(w.title)) {
                return
            }

[fthx]

Nope, I'll include a is_skip_taskbar filter. I'll check that very soon.

[fthx]

https://github.com/fthx/babar/commit/5445219a0fb0c5140a55afb9f4878cc7ef968704

Feel free to reopen if you still experience the issue.

[fthx]

It's online now, you should get a GNOME notification to update BaBar soon.