search

fthx / dock-from-dash

GNU General Public License v3.0
96 stars 20 forks source link

Use mouse wheel to change workspace #24

Closed rastersoft closed 2 years ago

rastersoft commented 2 years ago

Use mouse wheel to change workspace

This patch implements changing the current workspace by using the mouse wheel over the dock.

Fix https://github.com/fthx/dock-from-dash/issues/23

rastersoft commented 2 years ago

There is only one little problem with this: since the dock is about 16 pixels over the bottom of the screen, if you want to change the desktop you must go down to show the dock, and then move the mouse up to enter the dock. It would be better if the dock is completely at the bottom of the screen.

EDIT: Solved. It is ready.

fthx commented 2 years ago

Your code is better than what I did. The scroll part is the same but your way of changing workspaces is nicer (I did that with indexes!).

fthx commented 2 years ago

I did not reply on one point: the dock position is exactly the same as its overview position. So when the dock is displayed and you enter overview (for whatever unknown reason), there are no visual glitches.

rastersoft commented 2 years ago

Yes, it was my mistake: the reason why the scroll didn't work at the bottom was due to the widget that you use to detect when the mouse is there and show the dock. It was only a matter of connecting the scroll signal to it too.

rastersoft commented 2 years ago

BTW: now that this is implemented, what do you think about not hiding the dock after clicking on an icon to launch an app? Because I usually, at login, launch the mail client in the first workspace, switch to the next, launch firefox, switch to the next, and launch telegram, all in a row.

fthx commented 2 years ago

https://github.com/fthx/dock-from-dash/issues/26 to continue