fthx / dock-from-dash

GNU General Public License v3.0
97 stars 20 forks source link

Minimize on click function #3

Closed rcbern closed 2 years ago

rcbern commented 2 years ago

The title says it all, I think it would be more useful if a functionality as such exist, and perhaps having one wouldn't go far from the design and principle of the stock shell dock who could have that function if it were a dock. Thank you for this great extension!

fthx commented 2 years ago

Yes that's a good and simple feature and close to GS native behavior. I was thinking about this and your BR will make me try to handle this.

I'll do it if and only if GS native code allows me to hack dock items signals.

fthx commented 2 years ago

I tried and succeeded to make a signal on each dock app icon with a minimizing action but it interferes with this new GS dash instance behavior. Minimizing is not reliable at all, I suspect the dash of the dock is refreshed or something else...

So I consider this is out of the scope of this extension. I want to keep it simple, with a simple and reliable code.

fthx commented 2 years ago

I realize that I did not mention that this feature is complete now. I hacked the native GS click function in a reliable way.

rcbern commented 2 years ago

Hey that's great I thought you wouldn't continue pursuing it since it is already out of scope of this project, but you still did, thank you. I have another request relevant to this behavior if you may, perhaps the dock should not hide at the same time the minimize on click function is triggered, in that way it allows the user to seamlessly minimize and return an app to desktop without going down to show the dock every time an app is minimized. Thank you.

rcbern commented 2 years ago

or perhaps dock should not hide as long as the mouse is hovering over it?

fthx commented 2 years ago

The problem here is that the hover signal is not emitted correctly by GS. If you open an app through its menu (or change app) then leaving the dock and menu, the (lost) hover signal is not emitted and GS thinks the dock is still hovered... So I cannot check to not close the dock if it's still hovered because of false positive cases.

fthx commented 2 years ago

FYI it will be as you requested soon.