Several fixes - Githubissues

fthx / dock-from-dash

GNU General Public License v3.0

97 stars 20 forks source link

Several fixes #36

Closed rastersoft closed 2 years ago

rastersoft commented 2 years ago

Remove existing timeouts before assigning them again.
Return FALSE in timeout callbacks to ensure that the timeout isn't triggered again.
Disconnect the startup-complete signal.
Don't show the dock if an spurious "workarea-changed" signal is emitted (do it only if the resolution has changed)

Fix https://github.com/fthx/dock-from-dash/issues/35

fthx commented 2 years ago

Thanks for all that.

Can I put your name too in a commit I do? I don't know if it's possible and how to do this. I'll first manage the cleanup but I have some changes (e.g. there is no need to remove startup signal, since it's emitted only once per session, cf. No Overview extension, reviewed by Florian).

For workareas, I think I've got another much shorter solution. I'll have to test.

rastersoft commented 2 years ago

You can put it, of course, but don't feel forced to. Just take the pieces you need from this, there is no problem.

fthx commented 2 years ago

That's what I did! :-)