search

fthx / dock-from-dash

GNU General Public License v3.0
97 stars 20 forks source link

Sometimes enter unwanted overview on Thunderbird app icon clik #41

Closed fthx closed 1 year ago

fthx commented 2 years ago

Just remember here, that's due to this with Thunderbird: https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1932328

fthx commented 2 years ago

https://github.com/fthx/dock-from-dash/commit/7a6d6ec02c6b572d42945cc9dc81b52d79d4a8c1

@underlinejakez

fthx commented 2 years ago

Info maybe related? https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/e4446cd15ce46bcfddcd1e35ac3f0e70cb132991

fthx commented 2 years ago

https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/c02ca54943e8ee39356021bbb2c36b39c7f7e4e5

fthx commented 2 years ago

I reopen for future removing of our patch to this GS bug in extension itself.

Arcitec commented 2 years ago

@fthx The merged code is a correct patch and should NEVER be removed from Dash from Dock. It is not a GNOME Shell bug.

Removing "override-redirect" windows is extremely important. GNOME Shell itself also has to do the same work to take care to skip those windows everywhere when it's important to not include secret windows. The purpose of the "override-redirect" flag is "don't window-manage this window, at all".

Arcitec commented 2 years ago

After now looking at the GNOME commits you linked to, I can see however that they're working on hiding override-redirect windows from various APIs that you are using. So in that case, in the far future when enough people are using the patched GNOME Shell, then you could remove the manual check since the API itself won't return or activate OR windows.