search

fthx / dock-from-dash

GNU General Public License v3.0
96 stars 20 forks source link

fix: do not include hidden windows #42

Closed ghost closed 2 years ago

ghost commented 2 years ago

For some reason and apparently only using X11, apps like Firefox and Chromium opens a hidden window (and is not considered hidden but "Override-Redirect Window") that you can't see in "Activities" but it's counting. I don't know if this is the best way to solve it but it works.

fthx commented 2 years ago

https://github.com/fthx/dock-from-dash/issues/41

Thanks for that! I did not have the time to look after the correct window filter.

Arcitec commented 2 years ago

@fthx This is a correct patch and should NEVER be removed from Dash from Dock. It is not a GNOME Shell bug.

Removing "override-redirect" windows is extremely important. GNOME Shell itself also has to do the same work to take care to skip those windows everywhere when it's important to not include secret windows. The purpose of the "override-redirect" flag is "don't window-manage this window, at all".

Edit: I see now that GNOME Shell is working on removing those windows from the "get windows" API and the "activate window" API, so when everyone runs a patched GNOME Shell, it will be okay to remove the filter actually.